-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updateProposition support with completion in aepsdk-optimize-android #705
updateProposition support with completion in aepsdk-optimize-android #705
Conversation
…sitions and error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one comment before re-approval.
@@ -352,7 +352,7 @@ public static void updatePropositions(final List<DecisionScope> decisionScopes, | |||
* _decisionScopes_ is a list of decision scopes for which propositions need updating. | |||
* _xdm_ is a map containing additional xdm formatted data to be attached to the Experience Event. | |||
* _data_ is a map containing additional freeform data to be attached to the Experience Event. | |||
* _callback_ is a optional completion handler invoked at the completion of the edge request with map of successful decision scopes to propositions and errors, if any. | |||
* _callback_ is an optional completion handler that is invoked at the completion of the edge request. `call` method is invoked with propositions map of type `Map<DecisionScope, OptimizeProposition>`. If the callback is an instance of `AdobeCallbackWithOptimizeError`, and if the operation times out or an error occurs in retrieving propositions, the `fail` method is invoked with the appropriate [AdobeError](../../../home/base/mobile-core/tabs/api-reference.md#adobeerror). _Note:_ In certain cases, both the success and failure callbacks may be triggered. To handle these cases, ensure that your implementation checks for both successful propositions and errors within the callback, as both may be present simultaneously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit - Make the second sentence "The call
method is invoked..."
Optimize updateProposition support for completion callback with propositions and error
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: